Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: refactor query promises #802

Merged
merged 11 commits into from
Nov 17, 2023
Merged

style: refactor query promises #802

merged 11 commits into from
Nov 17, 2023

Conversation

krpeacock
Copy link
Contributor

Description

For clarity, refactors use of Promise in HttpAgent queries to use async across the board

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner November 17, 2023 17:39
@krpeacock krpeacock changed the title Kyle/refactor query promises style: refactor query promises Nov 17, 2023
Copy link
Contributor

github-actions bot commented Nov 17, 2023

size-limit report 📦

Path Size
@dfinity/agent 98.57 KB (-0.05% 🔽)
@dfinity/candid 13.41 KB (0%)
@dfinity/principal 5.01 KB (0%)
@dfinity/auth-client 90.58 KB (0%)
@dfinity/assets 91.11 KB (0%)
@dfinity/identity 88.06 KB (0%)
@dfinity/identity-secp256k1 254.38 KB (-0.02% 🔽)

@krpeacock krpeacock enabled auto-merge (squash) November 17, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant